jedcunningham commented on code in PR #55736:
URL: https://github.com/apache/airflow/pull/55736#discussion_r2356587400
##########
airflow-core/src/airflow/dag_processing/bundles/manager.py:
##########
@@ -34,52 +37,63 @@
from sqlalchemy.orm import Session
- from airflow.dag_processing.bundles.base import BaseDagBundle
-
_example_dag_bundle_name = "example_dags"
+class _ExternalBundleConfig(BaseModel):
Review Comment:
It might be worth having a comment/docstring as to what these are. Took me a
second as external/internal aren't immediately intuitive (at least to me).
##########
airflow-core/src/airflow/dag_processing/bundles/manager.py:
##########
@@ -152,8 +166,6 @@ def parse_config(self) -> None:
If a bundle class for a given name has already been imported, it will
not be imported again.
- todo (AIP-66): proper validation of the bundle configuration so we
have better error messages
Review Comment:
LGTM, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
