romsharon98 commented on code in PR #55802:
URL: https://github.com/apache/airflow/pull/55802#discussion_r2358484243
##########
chart/templates/secrets/redis-secrets.yaml:
##########
@@ -55,7 +55,7 @@ data:
password: {{ (default $random_redis_password .Values.redis.password) |
b64enc | quote }}
---
{{- end }}
-{{- if not .Values.data.brokerUrlSecretName }}
+{{- if and (not .Values.data.brokerUrlSecretName) (ne .Values.executor
"LocalExecutor") (ne .Values.executor "KubernetesExecutor") }}
Review Comment:
executor can be list so this will pass for
`LocalExecutor,KubernetesExecutor` for example.
I would change it to this
```suggestion
{{- if and (not .Values.data.brokerUrlSecretName) (or (contains
"CeleryExecutor" .Values.executor) (contains "CeleryKubernetesExecutor"
.Values.executor)) }}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
