Lee-W commented on code in PR #55749:
URL: https://github.com/apache/airflow/pull/55749#discussion_r2358716585


##########
providers/trino/src/airflow/providers/trino/assets/trino.py:
##########
@@ -26,6 +26,10 @@
 def sanitize_uri(uri: SplitResult) -> SplitResult:
     if not uri.netloc:
         raise ValueError("URI format trino:// must contain a host")
+    try:
+        _ = uri.port
+    except ValueError:
+        raise ValueError("URI format trino:// must contain a valid port")
     if uri.port is None:

Review Comment:
   I'm not sure we need this. We probably can make that a separate test case 
instead of using paramtereize?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to