vincbeck commented on code in PR #50960:
URL: https://github.com/apache/airflow/pull/50960#discussion_r2359234013
##########
providers/fab/pyproject.toml:
##########
@@ -70,11 +70,13 @@ dependencies = [
# Every time we update FAB version here, please make sure that you review
the classes and models in
# `airflow/providers/fab/auth_manager/security_manager/override.py` with
their upstream counterparts.
# In particular, make sure any breaking changes, for example any new
methods, are accounted for.
- "flask-appbuilder==4.6.3; python_version < '3.13'",
+ "flask-appbuilder==5.0.0; python_version < '3.13'",
"flask-login>=0.6.2; python_version < '3.13'",
# Flask-Session 0.6 add new arguments into the SqlAlchemySessionInterface
constructor as well as
# all parameters now are mandatory which make
AirflowDatabaseSessionInterface incompatible with this version.
- "flask-session>=0.4.0,<0.6; python_version < '3.13'",
+ "flask-session>=0.8.0; python_version < '3.13'",
+ "flask-sqlalchemy>=3.0.5; python_version < '3.13'",
+ "sqlalchemy<2; python_version < '3.13'",
Review Comment:
We need to pin down `sqlalchemy` below 2 because when sqlalchemy2 is used
`mypy` raises a lot of errors. Example:
https://github.com/apache/airflow/actions/runs/17811636991/job/50637132538?pr=50960.
I think we need to fix them all before enabling sqlalchemy2. @Dev-iL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
