Asquator commented on code in PR #55537:
URL: https://github.com/apache/airflow/pull/55537#discussion_r2359528331
##########
airflow-core/src/airflow/jobs/scheduler_job_runner.py:
##########
@@ -219,6 +191,14 @@ def __init__(
self.scheduler_dag_bag = DBDagBag(load_op_links=False)
+ task_selector_type = conf.get("scheduler.internal",
"task_selector_strategy")
+
+ if self._log:
+ self._log.info("Using %s task selector", task_selector_type)
+
+ self.task_selector = TASK_SELECTORS[task_selector_type]
+ self.task_selector_params_provider =
TASK_SELECTOR_PARAMS_PROVIDERS[task_selector_type]
+
Review Comment:
This is an internal abstraction for developers. It's not open to user
overrides. On merge the selector will be hardcoded / a better way to inject
will be found. I want to focus on the solution itself first and challenge it.
Let's postpone the clean-code decisions we talked about on mail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
