o-nikolas commented on code in PR #55703:
URL: https://github.com/apache/airflow/pull/55703#discussion_r2352929375
##########
providers/amazon/src/airflow/providers/amazon/aws/operators/batch.py:
##########
@@ -250,14 +250,22 @@ def execute(self, context: Context) -> str | None:
return self.job_id
- def execute_complete(self, context: Context, event: dict[str, Any] | None
= None) -> str:
+ def execute_complete(
+ self, context: Context, event: dict[str, Any] | None = None
+ ) -> str:
validated_event = validate_execute_complete_event(event)
if validated_event["status"] != "success":
raise AirflowException(f"Error while running job:
{validated_event}")
- self.log.info("Job completed.")
- return validated_event["job_id"]
+ self.job_id = validated_event["job_id"]
+
+ # Fetch logs if awslogs_enabled
+ if self.awslogs_enabled:
+ self.monitor_job(context) # fetch logs, no need to return
Review Comment:
We know the job is done by this point. Is `self.monitor_job` going to log
anything about starting to monitor again for a second time that will confuse
the users?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
