kaxil commented on a change in pull request #6489: [AIRFLOW-3959]
[AIRFLOW-4026] Add filter by DAG tags
URL: https://github.com/apache/airflow/pull/6489#discussion_r347050061
##########
File path: airflow/models/dag.py
##########
@@ -1384,7 +1390,8 @@ def sync_to_db(self, owner=None, sync_time=None,
session=None):
orm_dag.default_view = self._default_view
orm_dag.description = self.description
orm_dag.schedule_interval = self.schedule_interval
- session.merge(orm_dag)
+ orm_dag.tags = self.get_dagtags(session=session)
Review comment:
+1 on using JSON column. Don't mind if it is in same table or different.
Maybe makes sense to have it in the same Dag table just for consistency and
won't need a new class DagTag :D
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
