Pyasma opened a new pull request, #55928:
URL: https://github.com/apache/airflow/pull/55928
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**Summary**
This PR resolves a long-standing issue where the `VerticaHook` in the
`apache-airflow-providers-vertica` package failed to correctly construct a
SQLAlchemy connection URI. The previous implementation, which relied on the
default `DbApiHook.get_uri()` method, was unable to properly handle complex
connection parameters, especially those provided in the `extra` field of the
Airflow Connection.
This change introduces a new `sqlalchemy_url` property within the
`VerticaHook`. This property now correctly parses all connection attributes,
including the `host`, `port`, `login`, `password`, `schema` (database), and
most importantly, any key-value pairs from the `extra` field. The `get_uri()`
method is updated to return a valid string representation of this URL object,
ensuring that the hook can reliably connect to Vertica databases using a
correctly formed SQLAlchemy URI.
**Related Issues**
Closes #38195 (Specifically, the Vertica portion of this issue)
**Checklist**
- [x] I have rebased my branch to the latest `main` branch.
- [x] I have added a newsfragment for this change.
- [x] I have run `prek` and all checks passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
