pierrejeambrun commented on code in PR #55861:
URL: https://github.com/apache/airflow/pull/55861#discussion_r2368590613
##########
airflow-core/src/airflow/ui/src/components/PoolBar.tsx:
##########
@@ -69,17 +110,18 @@ export const PoolBar = ({
</Tooltip>
);
+ // Wrapper owns the proportional width, so segments butt together with
no gaps
return color !== "success" && "name" in pool ? (
- <Link asChild display="flex" flex={flexValue} key={key}>
+ <Link asChild display="flex" flex={correctedFlex} key={String(key)}>
Review Comment:
```suggestion
<Link asChild display="flex" flex={correctedFlex} key={key}>
```
##########
airflow-core/src/airflow/ui/src/components/PoolBar.tsx:
##########
@@ -69,17 +110,18 @@ export const PoolBar = ({
</Tooltip>
);
+ // Wrapper owns the proportional width, so segments butt together with
no gaps
return color !== "success" && "name" in pool ? (
- <Link asChild display="flex" flex={flexValue} key={key}>
+ <Link asChild display="flex" flex={correctedFlex} key={String(key)}>
<RouterLink
to={`/task_instances?${SearchParamsKeys.STATE}=${color}&${SearchParamsKeys.POOL}=${pool.name}`}
>
- {poolContent}
+ {inner}
</RouterLink>
</Link>
) : (
- <Box display="flex" flex={flexValue} key={key}>
- {poolContent}
+ <Box display="flex" flex={correctedFlex} key={String(key)}>
Review Comment:
```suggestion
<Box display="flex" flex={correctedFlex} key={key}>
```
##########
airflow-core/src/airflow/api_fastapi/core_api/openapi/v2-rest-api-generated.yaml:
##########
@@ -5403,9 +5403,7 @@ paths:
description: Successful Response
content:
application/json:
- schema:
- type: 'null'
- title: Response Delete Task Instance
Review Comment:
Those change are unrelated, why are we updating the API spec ?
##########
providers/edge3/src/airflow/providers/edge3/openapi/v2-edge-generated.yaml:
##########
@@ -142,9 +142,7 @@ paths:
description: Successful Response
content:
application/json:
- schema:
Review Comment:
Same here, edge provider is not related, can you remove that ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
