amoghrajesh commented on code in PR #55988:
URL: https://github.com/apache/airflow/pull/55988#discussion_r2372303186
##########
airflow-core/src/airflow/api_fastapi/common/parameters.py:
##########
@@ -285,7 +285,9 @@ def depends(cls, *args: Any, **kwargs: Any) -> Self:
def dynamic_depends(self, default: str | None = None) -> Callable:
def inner(
order_by: list[str] = Query(
- default=[default] if default is not None else
[self.get_primary_key_string()]
+ default=[default] if default is not None else
[self.get_primary_key_string()],
+ description=f"Attributes to order by, multi criteria sort is
supported. Prefix with `-` for descending order. "
+ f"Supported attributes: `{', '.join(self.allowed_attrs) if
self.allowed_attrs else self.get_primary_key_string()}`",
Review Comment:
```suggestion
description=f"Attributes to order results by, multi criteria
sort is supported. Prefix with `-` for descending order. "
f"Allowed attributes: `{', '.join(self.allowed_attrs) if
self.allowed_attrs else self.get_primary_key_string()}`",
```
nit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
