pwdsudinym-ui commented on code in PR #55339:
URL: https://github.com/apache/airflow/pull/55339#discussion_r2373946839
##########
airflow-core/src/airflow/ui/src/components/DurationChart.tsx:
##########
@@ -236,6 +236,9 @@ export const DurationChart = ({
stacked: true,
ticks: {
maxTicksLimit: 3,
+ callback: (value) => {
+ return(dayjs(value).format(getLabelFormat(entries)))
+ }
Review Comment:
I'm open to ideas but I think the question I'm trying to get at here is is:
how do I get all the times to play well with each other:
- We want onHover to show full date, but it uses the label to determine the
date to show
- We want the x axis to show truncated time, but this also uses the label to
determine what to show
- not using x axis `type: time` makes the callback values `0, 1, 2, ...`
- x axis `type: time` causes the bars to disappear
- x axis `type: time` will also cause time based scaling instead of just 1
bar after another like a classic bar chart
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
