pierrejeambrun commented on code in PR #55735:
URL: https://github.com/apache/airflow/pull/55735#discussion_r2382285904
##########
airflow-core/src/airflow/ui/src/constants/filterConfigs.tsx:
##########
@@ -61,6 +79,31 @@ export const useFilterConfigs = () => {
label: translate("common:dagId"),
type: FilterTypes.TEXT,
},
+ [SearchParamsKeys.DAG_ID_PATTERN]: {
+ hotkeyDisabled: true,
+ icon: <DagIcon />,
+ label: translate("common:dagId"),
+ type: FilterTypes.TEXT,
+ },
+ [SearchParamsKeys.DAG_VERSION]: {
+ hotkeyDisabled: true,
+ icon: <MdHistory />,
+ label: translate("common:dagRun.dagVersions"),
+ min: 1,
+ type: FilterTypes.NUMBER,
+ },
+ [SearchParamsKeys.DURATION_GTE]: {
+ icon: <MdHourglassEmpty />,
+ label: translate("common:filters.durationFrom", "Duration From"), // To
do: add translation key and remove default value
Review Comment:
> Adding the keys now would create temporary work for language owners, as
those keys would need to be removed once the new component is merged.
To be realistic I don't think any translation owner will work on translation
for `3.2.0` now. So even if we merge this it's very unlikely that people will
start translation for that.
If we do it the other way around though, the risk is that we forget to do
the translation for them, and that is worse I think.
I'm in favor of adding "Duration From" and "Duration To" translation keys
now, and you can remove that in your follow up PR for `date-selection`
component. (Also maybe other keys will be removed at that time)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
