vincbeck commented on code in PR #56106:
URL: https://github.com/apache/airflow/pull/56106#discussion_r2382405945
##########
providers/amazon/src/airflow/providers/amazon/aws/hooks/ses.py:
##########
@@ -101,6 +109,64 @@ def send_email(
custom_headers=custom_headers,
)
- return ses_client.send_raw_email(
+ return self.conn.send_raw_email(
Source=mail_from, Destinations=recipients, RawMessage={"Data":
message.as_string()}
)
+
+ async def asend_email(
Review Comment:
This comment applies to your other PR as well. Is prefixing the function
with `a` a convention? I am just wondering if this is obivous to
users/developers. Another alternative: prefixing with `async_`? I am not saying
your way is wrong, I am unsure this would make sense for the majority of
developers/users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
