ido177 opened a new issue, #56143:
URL: https://github.com/apache/airflow/issues/56143

   ### Official Helm Chart version
   
   1.18.0 (latest released)
   
   ### Apache Airflow version
   
   3.1.0
   
   ### Kubernetes Version
   
   1.31.6
   
   ### Helm Chart configuration
   
   _No response_
   
   ### Docker Image customizations
   
   _No response_
   
   ### What happened
   
   Currently, the chart sets both GIT_SYNC_* (v3 style) and GITSYNC_* (v4 
style) environment variables in the container.
   This was done for backward compatibility, but it introduces unnecessary 
duplication.
   Since the chart already allows specifying the git-sync image tag, we can 
reliably choose which set of variables to render based on the image version:
   If the tag is < 4.0.0 - use GIT_SYNC_* variables
   If the tag is >= 4.0.0 or latest - use GITSYNC_* variables
   
   ### What you think should happen instead
   
   Instead of 4 values ​​in the secret we can specify only 2
   
   ```
   ---
   apiVersion: v1
   kind: Secret
   metadata:
     name: git-credentials
   data:
     # For git-sync v3
     GIT_SYNC_USERNAME: <base64_encoded_git_username>
     GIT_SYNC_PASSWORD: <base64_encoded_git_password>
     # For git-sync v4
     GITSYNC_USERNAME: <base64_encoded_git_username>
     GITSYNC_PASSWORD: <base64_encoded_git_password>
   ```
   
   ### How to reproduce
   
   run gitSync in chart with dags.gitSync.credentialsSecret variable
   
   ### Anything else
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [x] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [x] I agree to follow this project's [Code of 
Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to