vincbeck commented on code in PR #55954:
URL: https://github.com/apache/airflow/pull/55954#discussion_r2382965563
##########
airflow-core/src/airflow/models/taskreschedule.py:
##########
@@ -49,16 +48,16 @@ class TaskReschedule(Base):
"""TaskReschedule tracks rescheduled task instances."""
__tablename__ = "task_reschedule"
- id = Column(Integer, primary_key=True)
- ti_id = Column(
+ id = mapped_column(Integer, primary_key=True)
+ ti_id = mapped_column(
String(36).with_variant(postgresql.UUID(as_uuid=False), "postgresql"),
ForeignKey("task_instance.id", ondelete="CASCADE",
name="task_reschedule_ti_fkey"),
nullable=False,
)
- start_date = Column(UtcDateTime, nullable=False)
- end_date = Column(UtcDateTime, nullable=False)
- duration = Column(Integer, nullable=False)
- reschedule_date = Column(UtcDateTime, nullable=False)
+ start_date = mapped_column(UtcDateTime, nullable=False)
+ end_date = mapped_column(UtcDateTime, nullable=False)
+ duration = mapped_column(Integer, nullable=False)
+ reschedule_date = mapped_column(UtcDateTime, nullable=False)
Review Comment:
Added them
##########
airflow-core/src/airflow/models/taskmap.py:
##########
@@ -63,13 +63,13 @@ class TaskMap(TaskInstanceDependencies):
__tablename__ = "task_map"
# Link to upstream TaskInstance creating this dynamic mapping information.
- dag_id = Column(String(ID_LEN, **COLLATION_ARGS), primary_key=True)
- task_id = Column(String(ID_LEN, **COLLATION_ARGS), primary_key=True)
- run_id = Column(String(ID_LEN, **COLLATION_ARGS), primary_key=True)
- map_index = Column(Integer, primary_key=True)
+ dag_id = mapped_column(String(ID_LEN, **COLLATION_ARGS), primary_key=True)
+ task_id = mapped_column(String(ID_LEN, **COLLATION_ARGS), primary_key=True)
+ run_id = mapped_column(String(ID_LEN, **COLLATION_ARGS), primary_key=True)
+ map_index = mapped_column(Integer, primary_key=True)
- length = Column(Integer, nullable=False)
- keys = Column(ExtendedJSON, nullable=True)
+ length = mapped_column(Integer, nullable=False)
+ keys = mapped_column(ExtendedJSON, nullable=True)
Review Comment:
Added them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
