zacharya19 commented on a change in pull request #6489: [AIRFLOW-3959]
[AIRFLOW-4026] Add filter by DAG tags
URL: https://github.com/apache/airflow/pull/6489#discussion_r347097267
##########
File path: airflow/www/views.py
##########
@@ -156,12 +158,19 @@ class AirflowBaseView(BaseView):
}
def render_template(self, *args, **kwargs):
- return super().render_template(
+ templ = super().render_template(
*args,
# Cache this at most once per request, not for the lifetime of the
view instance
scheduler_job=lazy_object_proxy.Proxy(jobs.SchedulerJob.most_recent_job),
**kwargs
)
+ resp = make_response(templ)
+ for k, v in kwargs.get('cookies', {}).items():
+ if v:
+ resp.set_cookie(k, v, expires=2147483647)
Review comment:
Changed to flask session.
Just and FYI - this change now makes the login session permanent as well (I
know it's not an API change, but it's a security backwards-incompatible
changes, so maybe I should write it in `UPDATING.md`?).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
