jscheffl commented on code in PR #56344:
URL: https://github.com/apache/airflow/pull/56344#discussion_r2399895730
##########
airflow-core/src/airflow/ui/src/components/DisplayMarkdownButton.tsx:
##########
@@ -48,14 +50,48 @@ const DisplayMarkdownButton = ({
open={isDocsOpen}
size="md"
>
- <Dialog.Content backdrop>
- <Dialog.Header bg="info.muted">
- <Heading size="xl">{header}</Heading>
- <Dialog.CloseTrigger closeButtonProps={{ size: "xl" }} />
- </Dialog.Header>
- <Dialog.Body alignItems="flex-start" as={VStack} gap="0">
- <ReactMarkdown>{mdContent}</ReactMarkdown>
- </Dialog.Body>
+ <Dialog.Content
+ backdrop
+ style={{
+ maxHeight: "none",
+ maxWidth: "none",
+ padding: 0,
+ width: "auto",
+ }}
+ >
+ <ResizableBox
+ height={600}
+ maxConstraints={[1200, 800]}
+ minConstraints={[512, 600]}
+ resizeHandles={["se"]}
+ style={{
+ backgroundColor: "inherit",
+ borderRadius: "inherit",
+ overflow: "hidden",
+ position: "relative",
+ }}
+ width={512}
Review Comment:
Would it make sense to remember the (last) size so that if you open another
Dag that it remembers the last size... such that users are not bothered to
resize over-and over again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
