ashb commented on code in PR #56270:
URL: https://github.com/apache/airflow/pull/56270#discussion_r2401419809
##########
task-sdk/src/airflow/sdk/io/path.py:
##########
@@ -413,5 +415,5 @@ def deserialize(cls, data: dict, version: int) ->
ObjectStoragePath:
def __str__(self):
conn_id = self.storage_options.get("conn_id")
if self._protocol and conn_id:
- return f"{self._protocol}://{conn_id}@{self.path}"
+ return
f"{self._protocol}://{conn_id}@{self.parser.join(*self._raw_urlpaths)}"
Review Comment:
Is this really the only options? Relying on a private method doesn't feel
great.
Could we do this instead:
`super(type(self), self).__str__(self.path)`
It's much more verbose, and opaque, yes, but it doesn't depend on accessing
a "private" method?
Or use `self.parts` somehow?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
