Ankurdeewan commented on PR #56324: URL: https://github.com/apache/airflow/pull/56324#issuecomment-3365734321
Thanks for the review @MaksYermak! Let me try to clarify a bit. The `impersonation_chain` and `quota_project_id `actually solve two different problems. Impersonation is about who is making the API call (identity), while the quota project is about which project is being billed for the request. For example, you could impersonate a service account from project A but still need the requests to be billed against project B. So they’re not overlapping, they’re complimentary and can definetly be used together. On the placement side, I added support for `quota_project_id ` both at the connection level (through extras) and in the operator `__init__`. My thinking was that connection extras work well as a default, but there are orgs where some tasks in a DAG need different quota billing, so having the param in `__init__` makes that possible. In the current code, the operator param takes precedence if both are set, which is the same pattern used for `project_id` in other GCP operators. That was the reasoning I went with, but of course happy to adjust if you feel it should be connection-only or if precedence should be handled differently. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
