HsiuChuanHsu commented on issue #56349: URL: https://github.com/apache/airflow/issues/56349#issuecomment-3368276257
>I completely agree with the rest you said. I believe termination_grace_period should be set explicitly in the pod spec when it is created, and I'd strip out this kwargs.update() stuff in on_kill(). Totally agree! I think we need to add `termination_grace_period_seconds` settings within the `k8s.V1PodSpec` construction in the `build_pod_request_obj()` method to creat the POD with the correct terminationGracePeriodSeconds value from the start. https://github.com/apache/airflow/blob/018ff3a9d1be1e47b5b66f0ba14167203ea86fab/providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/operators/pod.py#L1272-L1308 I'm going to try adding it and will run tests on the DAGs to confirm it resolves the issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
