anshuksi282-ksolves commented on PR #56476: URL: https://github.com/apache/airflow/pull/56476#issuecomment-3387063177
Hi @ephraimbuddy, Thank you for the detailed review and guidance! You are absolutely right. I agree that the change should be strictly surgical and focused only on the hash stability. I have cleaned up the branch, **reverted all unnecessary changes** (config template, extra method/arguments), and kept only the recursive sorting logic within `SerializedDagModel._sort_serialized_dag_dict`. I have also **verified the fix** by running the relevant unit tests in the Breeze environment, and they all passed: * `test_order_of_deps_is_consistent` **(PASSED)** * `test_serialized_dag_is_updated_if_dag_is_changed` **(PASSED)** The branch has been force-pushed with the minimal changes. Please take another look! Thanks, -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
