pierrejeambrun commented on code in PR #56030:
URL: https://github.com/apache/airflow/pull/56030#discussion_r2429101941
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/hitl.py:
##########
@@ -220,6 +220,8 @@ def get_hitl_details(
to_replace={
"dag_id": TI.dag_id,
"run_id": TI.run_id,
+ "task_id": TI.task_id,
Review Comment:
There is already a `ti_id` filter, why do we need to also allow for
`task_id`, it seems redundant.
##########
airflow-core/src/airflow/ui/src/pages/HITLTaskInstances/HITLTaskInstances.tsx:
##########
@@ -99,18 +122,37 @@ const taskInstanceColumns = ({
? []
: [
{
- accessorKey: "task_display_name",
+ accessorKey: "task_id",
Review Comment:
```suggestion
accessorKey: "task_id",
id: "ti_id",
```
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/hitl.py:
##########
@@ -220,6 +220,8 @@ def get_hitl_details(
to_replace={
"dag_id": TI.dag_id,
"run_id": TI.run_id,
+ "task_id": TI.task_id,
Review Comment:
Maybe we need some kind of aliasing capabilities in the front-end so we can
map the filter to `ti_id` instead.
##########
airflow-core/src/airflow/ui/src/pages/HITLTaskInstances/HITLTaskInstances.tsx:
##########
@@ -99,18 +122,37 @@ const taskInstanceColumns = ({
? []
: [
{
- accessorKey: "task_display_name",
+ accessorKey: "task_id",
Review Comment:
Here you can do the aliasing like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
