OmarFarooq908 opened a new pull request, #56399:
URL: https://github.com/apache/airflow/pull/56399
- Fix AttributeError: 'SparkKubernetesOperator' object has no attribute
'launcher'
- Add defensive checks in process_pod_deletion() and on_kill() methods
- Handle cases where launcher attribute is not available in deferrable mode
- Prevents crashes when process_pod_deletion() is called from
trigger_reentry()
- Maintains backward compatibility when launcher is available
- Shows appropriate warning when launcher is not available
Fixes #56291
The issue occurs because in deferrable mode:
1. execute() sets self.launcher during _setup_spark_configuration()
2. execute() defers to a trigger via execute_async()
3. When trigger completes, trigger_reentry() calls _clean() -> cleanup()
4. cleanup() calls process_pod_deletion() but self.launcher is not available
This fix adds defensive checks to handle both scenarios:
- When launcher is available (normal execution)
- When launcher is not available (deferrable mode trigger_reentry)
Tested with full Airflow environment to ensure the fix works correctly.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
