ashb commented on a change in pull request #6489: [AIRFLOW-3959] [AIRFLOW-4026] Add filter by DAG tags URL: https://github.com/apache/airflow/pull/6489#discussion_r347491899
########## File path: airflow/www/app.py ########## @@ -65,6 +66,7 @@ def create_app(config=None, session=None, testing=False, app_name="Airflow"): app.config['SESSION_COOKIE_HTTPONLY'] = True app.config['SESSION_COOKIE_SECURE'] = conf.getboolean('webserver', 'COOKIE_SECURE') app.config['SESSION_COOKIE_SAMESITE'] = conf.get('webserver', 'COOKIE_SAMESITE') + app.config['PERMANENT_SESSION_LIFETIME'] = timedelta(days=3560) # 10 years Review comment: This should either come from a config, or be set before line 61 (where we do `app.config.from_pyfile`) so that this setting can be changed from webserver_config.py. I think a 10year default is a bit too long a default too :) 14 or 30 days seems more reasonable ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services