potiuk edited a comment on issue #6597: [AIRFLOW-6005] Remove airflow airflow 
exception imports. Depends on [AIRFLOW-6004]
URL: https://github.com/apache/airflow/pull/6597#issuecomment-555279205
 
 
   @ashb - I looked at the options and now I implemented quickly version that 
does not do deprecation, but pre-commits. It requires:
   
   - 'from airflow import AirflowException' in "providers" and "contrib"
   - 'from airflow.exceptions import AirflowException' elsewhere
   
   I think that might make perfect sense rather than deprecating. It's even 
more "constraining" for core developers. The check is pretty much 
self-explanatory:
   
   ⌂66% [potiuk:/code/airflow] remove-airflow-airflow-exception-imports+ 
3d11h32m58s ± pre-commit run airflow-exception --all-files
   Make sure AirflowException is imported from airflow.exceptions in 
core.......................Passed
   Make sure AirflowException is imported from airflow outside of 
core..........................Passed
   [potiuk:/code/airflow] remove-airflow-airflow-exception-imports+ 3d11h33m25s 
± pre-commit run airflow-settings --all-files
   Make sure settings are imported individually as local 
imports.......................Passed
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to