potiuk commented on a change in pull request #6601: [AIRFLOW-6010] Remove
cyclic imports and pylint disables
URL: https://github.com/apache/airflow/pull/6601#discussion_r348320474
##########
File path: airflow/serialization/serialization.py
##########
@@ -244,8 +245,247 @@ def _value_is_hardcoded_default(cls, attrname, value):
return False
-if TYPE_CHECKING:
- from airflow.serialization.json_schema import Validator
- from airflow.serialization.serialized_baseoperator import
SerializedBaseOperator # noqa: F401, E501; # pylint: disable=cyclic-import
- from airflow.serialization.serialized_dag import SerializedDAG # noqa:
F401, E501; # pylint: disable=cyclic-import
- from inspect import Parameter
+class SerializedDAG(DAG, Serialization):
Review comment:
Comment here: I might likely be able to re-split the three classes. I will
try it after I run all the tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
