potiuk commented on a change in pull request #6601: [AIRFLOW-6010] Remove cyclic imports and pylint disables URL: https://github.com/apache/airflow/pull/6601#discussion_r348558188
########## File path: airflow/models/__init__.py ########## @@ -39,4 +38,5 @@ # Load SQLAlchemy models during package initialization # Must be loaded after loading DAG model. +# noinspection PyUnresolvedReferences Review comment: I like green checkmark when I solved all the warnings in PyCharm. I think it's also an indication that we deliberately ignored some problem which otherwise could be overlooked. It helps me (and I think I know at least few more people using pyCharm/IntelliJ and actually paying attention to warnings. I usually try to leave any file I am checking "clean" with regards to PyCharm's default warning settings. But If it's really annoying I can remove it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services