AutomationDev85 commented on code in PR #56875:
URL: https://github.com/apache/airflow/pull/56875#discussion_r2448005673
##########
providers/cncf/kubernetes/tests/unit/cncf/kubernetes/utils/test_pod_manager.py:
##########
@@ -700,6 +701,142 @@ def test_await_xcom_sidecar_container_starts(self,
mock_container_is_running):
mock_container_is_running.assert_any_call(mock_pod,
"airflow-xcom-sidecar")
+class TestAsyncPodManager:
+ def setup_method(self):
+ self.mock_async_hook = mock.AsyncMock()
+ self.async_pod_manager = AsyncPodManager(
+ async_hook=self.mock_async_hook,
+ callbacks=[],
+ )
+
+ @pytest.mark.asyncio
+ async def
test_start_pod_raises_informative_error_on_scheduled_timeout(self):
+ pod_response = mock.MagicMock()
+ pod_response.status.phase = "Pending"
+ self.mock_async_hook.get_pod.return_value = pod_response
+ expected_msg = "Pod took too long to be scheduled on the cluster,
giving up. More than 0s. Check the pod events in kubernetes."
+ mock_pod = mock.MagicMock()
+ with pytest.raises(AirflowException, match=expected_msg):
+ await self.async_pod_manager.await_pod_start(
+ pod=mock_pod,
+ schedule_timeout=0,
+ startup_timeout=0,
+ )
+ self.mock_async_hook.get_pod.assert_called()
+
+ @pytest.mark.asyncio
+ async def test_start_pod_raises_informative_error_on_startup_timeout(self):
+ pod_response = mock.MagicMock()
+ pod_response.status.phase = "Pending"
+ condition = mock.MagicMock()
+ condition.type = "PodScheduled"
+ condition.status = "True"
+ pod_response.status.conditions = [condition]
+ self.mock_async_hook.get_pod.return_value = pod_response
+ expected_msg = "Pod took too long to start. More than 0s. Check the
pod events in kubernetes."
+ mock_pod = mock.MagicMock()
+ with pytest.raises(AirflowException, match=expected_msg):
+ await self.async_pod_manager.await_pod_start(
+ pod=mock_pod,
+ schedule_timeout=0,
+ startup_timeout=0,
+ )
+ self.mock_async_hook.get_pod.assert_called()
+
+ @pytest.mark.asyncio
+ async def test_start_pod_raises_fast_error_on_image_error(self):
+ pod_response = mock.MagicMock()
+ pod_response.status.phase = "Pending"
+ container_status = mock.MagicMock()
+ waiting_state = mock.MagicMock()
+ waiting_state.reason = "ErrImagePull"
+ waiting_state.message = "Test error"
+ container_status.state.waiting = waiting_state
+ pod_response.status.container_statuses = [container_status]
+ self.mock_async_hook.get_pod.return_value = pod_response
+ expected_msg = f"Pod docker image cannot be pulled, unable to start:
{waiting_state.reason}\n{waiting_state.message}"
+ mock_pod = mock.MagicMock()
+ with pytest.raises(AirflowException, match=expected_msg):
+ await self.async_pod_manager.await_pod_start(
+ pod=mock_pod,
+ schedule_timeout=60,
+ startup_timeout=60,
+ )
+ self.mock_async_hook.get_pod.assert_called()
+
+ @pytest.mark.asyncio
+ @mock.patch("asyncio.sleep", new_callable=mock.AsyncMock)
+ async def test_start_pod_startup_interval_seconds(self, mock_time_sleep,
caplog):
Review Comment:
I will remove this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
