jason810496 commented on code in PR #56813:
URL: https://github.com/apache/airflow/pull/56813#discussion_r2464497609
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/xcom.py:
##########
@@ -193,8 +194,10 @@ def get_xcom_entries(
query = query.order_by(
XComModel.dag_id, XComModel.task_id, XComModel.run_id,
XComModel.map_index, XComModel.key
)
- xcoms = session.scalars(query)
- return XComCollectionResponse(xcom_entries=xcoms,
total_entries=total_entries)
+ xcoms = session.scalars(query).all()
+ return XComCollectionResponse(
+ xcom_entries=[XComResponse.from_orm(xcom) for xcom in xcoms],
total_entries=total_entries
Review Comment:
Will MyPy raise error if we just use `session.scalars(query)` ?
```suggestion
xcom_entries=session.scalars(query), total_entries=total_entries
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
