feluelle commented on a change in pull request #6472: [AIRFLOW-6058] Running 
tests with pytest
URL: https://github.com/apache/airflow/pull/6472#discussion_r350278910
 
 

 ##########
 File path: airflow/www/views.py
 ##########
 @@ -1024,12 +1024,12 @@ def blocked(self, session=None):
             )
             if 'all_dags' not in filter_dag_ids:
                 dags = dags.filter(DR.dag_id.in_(filter_dag_ids))
-            dags = dags.all()
+            else:
 
 Review comment:
   I am not sure if this is correct. 
[all()](https://docs.sqlalchemy.org/en/13/orm/query.html#sqlalchemy.orm.query.Query.all)
 collects the dags - 
[filter()](https://docs.sqlalchemy.org/en/13/orm/query.html#sqlalchemy.orm.query.Query.filter)
 does only filter the dags but not collect them.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to