This is an automated email from the ASF dual-hosted git repository.
amoghdesai pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 47f5e22e550 `issue-58718`: Adding Task SDK integration tests for
`Variable` operations (#58357)
47f5e22e550 is described below
commit 47f5e22e5507777e8bfecbf1146a9c75b9c9cc29
Author: Jake Roach <[email protected]>
AuthorDate: Mon Nov 17 11:33:16 2025 -0500
`issue-58718`: Adding Task SDK integration tests for `Variable` operations
(#58357)
---
.../task_sdk_tests/test_variable_operations.py | 62 ++++++++++++++++++----
1 file changed, 52 insertions(+), 10 deletions(-)
diff --git
a/task-sdk-integration-tests/tests/task_sdk_tests/test_variable_operations.py
b/task-sdk-integration-tests/tests/task_sdk_tests/test_variable_operations.py
index 9bb8245f82d..e1d538eb2dd 100644
---
a/task-sdk-integration-tests/tests/task_sdk_tests/test_variable_operations.py
+++
b/task-sdk-integration-tests/tests/task_sdk_tests/test_variable_operations.py
@@ -19,15 +19,15 @@
Integration tests for Variable operations.
These tests validate the Execution API endpoints for Variable operations:
-- get(): Get variable value
+- get(): Get Variable value (positive, negative)
+- set(): Set Variable value
+- delete(): Delete Variable value
"""
from __future__ import annotations
-import pytest
-
from airflow.sdk.api.datamodels._generated import VariableResponse
-from airflow.sdk.execution_time.comms import ErrorResponse
+from airflow.sdk.execution_time.comms import ErrorResponse, OKResponse
from task_sdk_tests import console
@@ -76,7 +76,6 @@ def test_variable_get_not_found(sdk_client):
console.print("[green]✅ Variable get (not found) test passed!")
[email protected](reason="TODO: Implement Variable set test")
def test_variable_set(sdk_client):
"""
Test setting variable value.
@@ -84,11 +83,19 @@ def test_variable_set(sdk_client):
Expected: OKResponse with ok=True
Endpoint: PUT /execution/variables/{key}
"""
- console.print("[yellow]TODO: Implement test_variable_set")
- raise NotImplementedError("test_variable_set not implemented")
+ response = sdk_client.variables.set("test_variable_key",
"test_variable_value")
+
+ console.print(" Variable Set Response ".center(72, "="))
+ console.print(f"[bright_blue]Response Type:[/] {type(response).__name__}")
+ console.print(f"[bright_blue]Status:[/] {response.ok}")
+ console.print("=" * 72)
+
+ assert isinstance(response, OKResponse)
+ assert response.ok is True
+
+ console.print("[green]✅ Variable set test passed!")
[email protected](reason="TODO: Implement Variable delete test")
def test_variable_delete(sdk_client):
"""
Test deleting variable value.
@@ -96,5 +103,40 @@ def test_variable_delete(sdk_client):
Expected: OKResponse with ok=True
Endpoint: DELETE /execution/variables/{key}
"""
- console.print("[yellow]TODO: Implement test_variable_delete")
- raise NotImplementedError("test_variable_delete not implemented")
+ console.print("[yellow]Deleting variable...")
+
+ # When using the test_variable_key, we noticed an issue where it appears
that the variable that was
+ # being set/deleted was still available when retrieved later. Per
@amoghrajesh, in Docker Compose [we've]
+ # defined an environment variable for test_variable_key and secrets
backends are read-only, so when [our]
+ # test calls Variable.set(), the value is written to the database — and
when you delete it, Airflow
+ # correctly removes it from the DB... However, a calling Variable.get()
once the Variable had been
+ # deleted pointed to the Secrets Backend, which still had that key
available.
+ key: str = "test_variable_delete_key"
+
+ # First, set the variable
+ sdk_client.variables.set(key, "test_variable_value")
+
+ # Now, delete the variable
+ response = sdk_client.variables.delete(key)
+
+ console.print(" Variable Delete Response ".center(72, "="))
+ console.print(f"[bright_blue]Response Type:[/] {type(response).__name__}")
+ console.print(f"[bright_blue]Status:[/] {response.ok}")
+ console.print("=" * 72)
+
+ assert isinstance(response, OKResponse)
+ assert response.ok is True
+
+ # Validate that the Variable has in fact been deleted
+ get_response = sdk_client.variables.get(key)
+
+ console.print(" Variable Get After Delete ".center(72, "="))
+ console.print(f"[bright_blue]Response Type:[/]
{type(get_response).__name__}")
+ console.print(f"[bright_blue]Error Type:[/] {get_response.error}")
+ console.print(f"[bright_blue]Detail:[/] {get_response.detail}")
+ console.print("=" * 72)
+
+ assert isinstance(get_response, ErrorResponse)
+ assert str(get_response.error).find("VARIABLE_NOT_FOUND") != -1
+
+ console.print("[green]✅ Variable delete test passed!")
