potiuk commented on code in PR #58430:
URL: https://github.com/apache/airflow/pull/58430#discussion_r2539241139
##########
dev/breeze/tests/test_selective_checks.py:
##########
@@ -2779,3 +2779,169 @@ def
test_testable_providers_integrations_excludes_arm_disabled_on_arm():
assert "postgres" in result
assert "trino" not in result
assert "ydb" not in result
+
+
+@patch("airflow_breeze.utils.selective_checks.run_command")
+def test_provider_dependency_bump_check_no_changes(mock_run_command):
+ """Test that provider dependency bump check passes when no pyproject.toml
files are changed."""
+ selective_checks = SelectiveChecks(
+ files=("some_other_file.py",),
+ commit_ref=NEUTRAL_COMMIT,
+ pr_labels=(),
+ github_event=GithubEvents.PULL_REQUEST,
+ default_branch="main",
+ )
+ result = selective_checks.provider_dependency_bump
+ assert result is False
+
+
+@patch("airflow_breeze.utils.selective_checks.run_command")
+def
test_provider_dependency_bump_check_fails_on_provider_version_bump(mock_run_command):
Review Comment:
Yes. We do it very often - for example when Amazon provider expects a new
feature from google provider in "transfer" operator (happened a few times) or
when google provider expected new features from beam provider (happened more
than once) - or when about 20 providers expected new feature from openlineage
provider or when we had new feature in common.compat we wanted to add.
Last time it happend was few days ago when new compat feature was added and
apprise and slack provider used new feature from common.compat -resulting in
removing both of them from rc1 and creating rc2.
In this case we **really** want people to try to bump the version of
providers (if they have never read the documentation and learn from the failure
what they should do.
So **yeah** absolutely we want to test it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
