zachliu opened a new issue, #59348:
URL: https://github.com/apache/airflow/issues/59348

   ### Apache Airflow version
   
   3.1.4
   
   ### If "Other Airflow 2/3 version" selected, which one?
   
   _No response_
   
   ### What happened?
   
   In Airflow 3.1.4, the `ApprovalOperator`’s `assigned_users` argument appears 
to depend on the configured auth manager.
   
   When I use `SimpleAuthManager` and set 
`simple_auth_manager_all_admins=True`, `assigned_users` becomes effectively 
unusable: no one can approve or reject in the UI.
   
   <img width="1456" height="891" alt="Image" 
src="https://github.com/user-attachments/assets/e726f40c-27be-4a42-92d4-69c9599d7396";
 />
   
   I suspect this is because when `simple_auth_manager_all_admins=True`, 
`SimpleAuthManager` does not create/populate the `ab_user` table, so 
`assigned_users` has no user table to resolve against.
   
   ### What you think should happen instead?
   
   When `simple_auth_manager_all_admins=True`, `ApprovalOperator` should ignore 
`assigned_users` (or treat it as “everyone”) and allow all logged-in users to 
approve/reject, since “all admins” mode implies there is no real user directory 
backing `assigned_users`.
   
   (Alternatively, Airflow could validate this configuration and raise a clear 
error explaining that assigned_users requires a real user store, but the 
current behavior is a silent “nobody can approve.”)
   
   ### How to reproduce
   
   1. Configure the auth manager to SimpleAuthManager
   2. Set `simple_auth_manager_all_admins` to `True`
   3. Create a DAG that uses `ApprovalOperator` with `assigned_users` set to 
one or more usernames or simple `None`
   4. Trigger the DAG and open the approval UI
   
   ### Operating System
   
   LM 21.3 with docker python:3.12-slim-bookworm
   
   ### Versions of Apache Airflow Providers
   
   _No response_
   
   ### Deployment
   
   Docker-Compose
   
   ### Deployment details
   
   _No response_
   
   ### Anything else?
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [x] I agree to follow this project's [Code of 
Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to