ashb commented on a change in pull request #6596: [AIRFLOW-6004] Untangle
Executors class to avoid cyclic imports
URL: https://github.com/apache/airflow/pull/6596#discussion_r352299897
##########
File path: airflow/models/dagbag.py
##########
@@ -317,9 +317,7 @@ def kill_zombies(self, zombies, session=None):
had a heartbeat for too long, in the current DagBag.
:param zombies: zombie task instances to kill.
- :type zombies: airflow.utils.dag_processing.SimpleTaskInstance
Review comment:
It sounds like we should add this back, it's for docs not the type syste
anyway.
The way to avoid imported modules/classes becoming part of the public API of
this module is to use `__all__`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
