nuclearpinguin commented on a change in pull request #6713: Add some r/w 
functionality to GCP Bigtable Hook
URL: https://github.com/apache/airflow/pull/6713#discussion_r352819063
 
 

 ##########
 File path: airflow/gcp/hooks/bigtable.py
 ##########
 @@ -276,3 +278,58 @@ def get_cluster_states_for_table(instance: Instance, 
table_id: str) -> Dict[str,
 
         table = Table(table_id, instance)
         return table.get_cluster_states()
+
+    def create_rowkey_regex_filter(self, regex):
+        """
+        A helper method to create a RowKeyRegexFilter subclass of RowFilter, 
which
+        will only match rows with keys that exactly match the regex string.
+        Returns a RowFilter.
+
+        :type regex: str
+        :param regex: The exact match regex string for the value we wish to 
find
+        """
+        return RowKeyRegexFilter(regex)
+
+
+    def delete_row(self, instance, table_id, row_key):
 
 Review comment:
   Please add type annotations.
   ```suggestion
       def delete_row(self, instance: Instance, table_id: str, row_key: str) -> 
None:
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to