jason810496 commented on code in PR #55068:
URL: https://github.com/apache/airflow/pull/55068#discussion_r2671276733


##########
airflow-core/src/airflow/jobs/triggerer_job_runner.py:
##########
@@ -944,9 +975,19 @@ async def init_comms(self):
             raise RuntimeError(f"Required first message to be a 
messages.StartTriggerer, it was {msg}")
 
     async def create_triggers(self):
+        def create_runtime_ti(encoded_dag: dict) -> RuntimeTaskInstance:
+            task = 
DagSerialization.from_dict(encoded_dag).get_task(workload.ti.task_id)
+
+            # I need to recreate a TaskInstance from task_runner before 
invoking get_template_context (airflow.executors.workloads.TaskInstance)
+            return RuntimeTaskInstance.model_construct(
+                **workload.ti.model_dump(exclude_unset=True),
+                task=task,
+            )

Review Comment:
   > I'm stuck again now with this PR as the get_template_context method got 
removed from TaskInstance now only exists in RuntimeTaskInstance.
   
   Do you mean this part?
   
   > Maybe I could create a RuntimeTaskInstance from TaskInstance?
   
   I think this is the only way to call the `get_template_context` right now, 
exactly as you implemented it here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to