SameerMesiah97 commented on PR #60254: URL: https://github.com/apache/airflow/pull/60254#issuecomment-3739977874
> @jscheffl Thank you for your input. This is a good suggestion, and I've implemented the changes accordingly. > > @SameerMesiah97 Thank you for the feedback. I've implemented a dynamic approach where the client-side timeout now depends on the server-side timeout. If the server-side timeout exceeds the default API_TIMEOUT, the client-side timeout is set to the server-side timeout plus an offset. This ensures the server has adequate time to respond before the client times out. I believe this is a more robust solution than simply documenting the behavior. Great. That is even better as it makes the timeout behave more in line with user expectations. I do not want to sound pedantic here but I think this dynamic approach towards handling conflicting timeouts should be mentioned in the docstring for `def watch_pod_events`. Maybe something like: `timeout_seconds – Timeout in seconds for the watch stream. A small additional buffer may be applied internally.` Though the 5 second default is quite short, users scouring the logs might notice the discrepancy and think this is unintentional. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
