pierrejeambrun commented on code in PR #60609:
URL: https://github.com/apache/airflow/pull/60609#discussion_r2697967730


##########
airflow-core/src/airflow/ui/src/pages/TaskInstances/TaskInstances.tsx:
##########
@@ -235,7 +235,7 @@ export const TaskInstances = () => {
   });
   const { pagination, sorting } = tableURLState;
   const [sort] = sorting;
-  const orderBy = sort ? [`${sort.desc ? "-" : ""}${sort.id}`] : 
["-start_date", "-run_after"];
+  const orderBy = sort ? [`${sort.desc ? "-" : ""}${sort.id}`] : 
["-run_after"];

Review Comment:
   The second sort criteria was explicitely added in 
https://github.com/apache/airflow/pull/53804. I'd prefer we keep it to avoid 
any confusion, also it makes sense if there are a lot of TIs and some of them 
have the same `start_date`. (instead of defaulting to 'task_id' as a second 
criteria)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to