vatsrahul1001 commented on PR #59754: URL: https://github.com/apache/airflow/pull/59754#issuecomment-3759511345
> @vatsrahul1001 > > Hey, thanks for sticking with me on this - I know it's taken way longer than it should have. Really appreciate you taking the time to explain the patterns. > > Just pushed a fix removing the LoginPage stuff (finally caught what you meant about not using login in pages). Looked at how the other merged PRs handle auth (#59943, #59919, etc.) and matched that pattern - just using the global storageState: AUTH_FILE instead. > > Quick summary of what changed: > > Removed LoginPage completely Tests get the authenticated page directly from Playwright config now All the other stuff you mentioned is addressed too (beforeAll, separate file, filtering) If there's anything else that needs fixing, let me know and I'll get on it. > > But honestly, if you'd rather hand this off to someone else at this point, I totally get it - I know I've already taken up a lot of your time. > > Thanks again for the help! Thanks for the changes @Sahil-Shadwal, I see static checks and tests are still failing can you have a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
