dabla commented on code in PR #60369:
URL: https://github.com/apache/airflow/pull/60369#discussion_r2708649216
##########
providers/microsoft/azure/src/airflow/providers/microsoft/azure/operators/powerbi.py:
##########
@@ -65,6 +65,7 @@ class PowerBIDatasetRefreshOperator(BaseOperator):
:param check_interval: Number of seconds to wait before rechecking the
refresh status.
:param request_body: Additional arguments to pass to the request body, as
described in
https://learn.microsoft.com/en-us/rest/api/power-bi/datasets/refresh-dataset-in-group#request-body.
+ :param wait_for_termination: If True, wait for the dataset refresh to
complete. If False, trigger the refresh and return immediately without waiting.
Review Comment:
Yes, but I agree with @eladkal , the existing deferrable parameter is
confusing. The new parameter I’m fine with, but maybe it’s not needed at all. I
think deferrable should be deprecated as in my opinion it doesn’t make sense. I
would make the waiting purely in deferrable mode and remove the blocking part
and keep the new part you did @shreyas-dev as this is how it should have been
implemented from the beginning. I willl check back tonight and come back to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
