vincbeck commented on code in PR #60675:
URL: https://github.com/apache/airflow/pull/60675#discussion_r2713195448
##########
providers/celery/src/airflow/providers/celery/executors/celery_executor_utils.py:
##########
@@ -102,6 +104,38 @@ def _get_celery_app() -> Celery:
return Celery(celery_app_name, config_source=get_celery_configuration())
+def create_celery_app(team_conf) -> Celery:
Review Comment:
Do we know the type? If yes, it would be better to have type annotation
##########
providers/celery/src/airflow/providers/celery/executors/celery_executor.py:
##########
@@ -206,6 +217,8 @@ def _send_tasks_to_celery(self, task_tuples_to_send:
Sequence[TaskInstanceInCele
chunksize = self._num_tasks_per_send_process(len(task_tuples_to_send))
num_processes = min(len(task_tuples_to_send), self._sync_parallelism)
+ # Use ProcessPoolExecutor with team_name instead of task objects to
avoid pickling issues.
Review Comment:
I do not see it being used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
