rachanadutta commented on code in PR #60591: URL: https://github.com/apache/airflow/pull/60591#discussion_r2713422305
########## airflow-core/src/airflow/ui/src/components/Clear/TaskInstance/ClearAllMappedTaskInstancesDialog.tsx: ########## @@ -0,0 +1,200 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { Button, Flex, Heading, useDisclosure, VStack } from "@chakra-ui/react"; +import { useState } from "react"; +import { useTranslation } from "react-i18next"; +import { CgRedo } from "react-icons/cg"; + +import type { TaskInstanceResponse } from "openapi/requests/types.gen"; +import { ActionAccordion } from "src/components/ActionAccordion"; +import { Checkbox, Dialog } from "src/components/ui"; +import SegmentedControl from "src/components/ui/SegmentedControl"; +import { useClearTaskInstances } from "src/queries/useClearTaskInstances"; +import { useClearTaskInstancesDryRun } from "src/queries/useClearTaskInstancesDryRun"; +import { isStatePending, useAutoRefresh } from "src/utils"; + +import ClearTaskInstanceConfirmationDialog from "./ClearTaskInstanceConfirmationDialog"; + +type Props = { + readonly dagId: string; + readonly dagRunId: string; + readonly onClose: () => void; + readonly open: boolean; + readonly taskId: string; +}; + +const ClearAllMappedTaskInstancesDialog = ({ + dagId, + dagRunId, + onClose: onCloseDialog, + open: openDialog, + taskId, +}: Props) => { + const { t: translate } = useTranslation(); + const { onClose, onOpen, open } = useDisclosure(); + + const { isPending, mutate } = useClearTaskInstances({ + dagId, + dagRunId, + onSuccessConfirm: onCloseDialog, + }); Review Comment: Thanks for pointing this out. Just to clarify, this is a pre-existing UI issue and not introduced by this PR. I had already opened a separate bug issue a few days ago to track this, since it reproduces on released Airflow as well (tested on 3.1.3 and 3.1.6 with airflow standalone). The backend clears correctly, but the relevant UI queries (TI list / detail view) are not invalidated, which is why the old state remains visible. So this seems to be a pre-existing UI query invalidation issue, not introduced by this PR. To avoid mixing concerns, I’ve opened a separate bug issue to track this properly, since it affects core UI behavior beyond mapped tasks and this feature. Since this PR is focused on adding the “Clear all mapped task instances” action, I thought it would be better not to mix concerns here. Issue: #60703 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
