l0n3r4n83r opened a new pull request #6745: [Airflow-5144] confirmation 
dialogue on delete
URL: https://github.com/apache/airflow/pull/6745
 
 
   As per https://github.com/flask-admin/flask-admin/issues/1789 the deleted 
button did not show a confirmation alert. This issue has
   been fixed in newer version of flask-admin
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following 
[AIRFLOW-5144](https://issues.apache.org/jira/browse/AIRFLOW-5144) issues and 
references them in the PR title. 
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI 
changes:
   Confirmation dialogue on click of delete was not showing up due to 
https://github.com/flask-admin/flask-admin/issues/1789 since the fix is now 
merged this PR upgrades the flask-admin version. I have tested creating and 
deleting variables and connections on the UI. A screenshot with the 
confirmation dialogue appearing on delete is attached.
   
   
![image](https://user-images.githubusercontent.com/2957301/70321865-c91b7600-1828-11ea-8e3f-27f95e57e334.png)
   
   
   ### Tests
   
   - [ ] My PR add not need testing for this extremely good reason: AFAIK no 
unit tests exists for UI
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
     1. The subject is separated from the body by a blank line
   
   ### Documentation
   
   - [ ] This is restoring the functionality of confirmation dialogue before 
deleting a variable or connection. 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to