arjav1528 commented on PR #60161:
URL: https://github.com/apache/airflow/pull/60161#issuecomment-3795383569
Thanks for the reviews @jason810496 @pierrejeambrun @bbovenzi! I've
addressed all the feedback:
Backend fixes:
✅ Removed the unreachable duplicate return statement in patch_task_instance
✅ Created a separate bulk_task_instances_dry_run endpoint instead of using a
dry_run query parameter - this avoids the union return type (BulkResponse |
TaskInstanceCollectionResponse) that was causing client-side confusion
✅ Removed the unused _validate_patch_request_body function (dead code)
✅ Reverted the unrelated CI timeout change in run-unit-tests.yml
Frontend fixes: 5. ✅ Fixed usePatchTaskGroup.ts to call the correct endpoint
{identifier}?task_group_id=... instead of the non-existent {task_group_id} 6. ✅
Fixed usePatchTaskGroupDryRun.ts to call dry_run?task_group_id=... instead of
dry_run
The UI was previously calling endpoints that didn't exist in the backend,
which would have caused all task group mark-as operations to fail with 404
errors.
Ready for another review when you have time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
