Eason09053360 commented on PR #61057: URL: https://github.com/apache/airflow/pull/61057#issuecomment-3809527308
Thank you for pointing me to PR #61059. I've reviewed the fix and understand that [Plugins.tsx](vscode-file://vscode-app/private/var/folders/t1/h_k93r3d1s3dll_y05d15s2r0000gn/T/AppTranslocation/BF8D318F-893D-4D2D-BAEB-FE863494B6E3/d/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/code/electron-browser/workbench/workbench.html) now correctly implements pagination support However, the pagination E2E test still fails in the current test environment. The test environment only has 7 built-in plugins: <img width="1920" height="1010" alt="截圖 2026-01-28 下午3 27 45" src="https://github.com/user-attachments/assets/18bd5457-eb1c-43b0-b1df-7208f09f5f4a"; /> I tested with [limit=5&offset=0](vscode-file://vscode-app/private/var/folders/t1/h_k93r3d1s3dll_y05d15s2r0000gn/T/AppTranslocation/BF8D318F-893D-4D2D-BAEB-FE863494B6E3/d/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/code/electron-browser/workbench/workbench.html) to trigger pagination: Expected: 2 pages (5 plugins on page 1, 2 on page 2) → pagination controls should appear Actual: Pagination controls are not visible in the UI Root cause: The DataTable component hides pagination controls when conditions in [hasPagination](vscode-file://vscode-app/private/var/folders/t1/h_k93r3d1s3dll_y05d15s2r0000gn/T/AppTranslocation/BF8D318F-893D-4D2D-BAEB-FE863494B6E3/d/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/code/electron-browser/workbench/workbench.html) are not met: const hasPagination = initialState?.pagination !== undefined && (pageIndex !== 0 || rows.length !== total); When navigating to [/plugins?limit=5&offset=0](vscode-file://vscode-app/private/var/folders/t1/h_k93r3d1s3dll_y05d15s2r0000gn/T/AppTranslocation/BF8D318F-893D-4D2D-BAEB-FE863494B6E3/d/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/code/electron-browser/workbench/workbench.html), the URL parameters seem to get cleared during React initialization, resulting in all 7 plugins being displayed on a single page without pagination controls. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
