o-nikolas commented on code in PR #61079: URL: https://github.com/apache/airflow/pull/61079#discussion_r2738502865
########## shared/observability/src/airflow_shared/observability/metrics/stats.py: ########## @@ -29,6 +30,36 @@ log = logging.getLogger(__name__) +_VALID_STAT_NAME_CHARS_RE = re.compile(r"^[a-zA-Z0-9_.-]+$") +_INVALID_STAT_NAME_CHARS_RE = re.compile(r"[^a-zA-Z0-9_.-]") Review Comment: Yeah, on this one I think I'll keep it as is. I really just want to move over the impl that existed before with no changes. It's very possible to generalize this further but I think that drifts too far from the original intention of this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
