subhash-0000 commented on PR #61281: URL: https://github.com/apache/airflow/pull/61281#issuecomment-3834039963
Thanks for the review @jason810496 I hear you on the concern regarding code changes for an edge case. However, I’d like to propose a compromise of Code + Docs for a few key reasons: Solving the mystery of #53105: That issue was closed as 'Not Planned' primarily because the root cause was unknown and it was thought to be environment-specific. This PR proves it’s a core Airflow/uvloop incompatibility on Python 3.13+. By fixing this in code, we officially resolve that long-standing mystery. Segfaults are "silent" killers: Since PYTHONASYNCIODEBUG is a standard Python flag (not Airflow-specific), developers often enable it without checking application-specific docs. If it leads to a hard segmentation fault, there is no log output to tell them why it crashed, leading to more issues being opened here. Minimal Overhead: The fix is a simple defensive check at the entry point. It ensures that when a user asks for 'Debug Mode,' Airflow prioritizes stability (standard loop) over performance (uvloop). How about this: I will keep the defensive code fix to prevent the crash, but I will also add a note to the user-facing documentation as you suggested, explaining the fallback. This provides 'defense-in-depth'—the code prevents the crash, and the docs explain why. Would you be open to this approach? I'm happy to push the doc updates to this PR immediately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
