vincbeck commented on PR #61195:
URL: https://github.com/apache/airflow/pull/61195#issuecomment-3835560875
Let's try to untangle things here :) A per my understanding, before the
operator had only `wait_policy` to configure whether you want to wait or not.
That's why I created #56153, for consistency purposes, all across AWS operator
we use `wait_for_completion` to configure whether you want the operator to
wait. Hence, we should keep it.
Now, it seems you also want to have different options of waiting, which is
fine. I do not think it is a problem to un-deprecate a parameter either.
Though, we need to be careful and be backward compatible and handle all the
different possibilities:
- If `wait_for_completion` is `True`:
- If `wait_policy` is not defined (or `None`), default should be
`WaitPolicy.WAIT_FOR_COMPLETION`. As a user, I should not have to set 2
parameters (`wait_for_completion` and `wait_policy`) if I want to wait
- If `wait_for_completion` is `False`:
- If `wait_policy` is set, then set `wait_for_completion` to True and
raise a deprecation warning saying that `wait_for_completion` must be set to
True in order to wait
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
