jscheffl commented on PR #61318: URL: https://github.com/apache/airflow/pull/61318#issuecomment-3835876661
> > (1) the package-lock.json should not be committed. You can setup your devenv as described in https://github.com/apache/airflow/blob/main/contributing-docs/03a_contributors_quick_start_beginners.rst and with prek the static assets are locally re-generated including the needed www-hash.txt > > (2) Please check the PR template banner and use the template > > (3) I assume the fix is not working by reading the code. Please check with the commands given in the issue title included if it really fixes. I do not see how a pre-release suffix shall be cut and frankly speaking the fix looks like AI slop > > Unrelated to current PR but related to the release process. I submitted another PR and noticed that the www-hash.txt that was generated on my laptop differed from the one generated by CI / CD tool. I assumed it might be related to using mac and linux on ci/cd. Does that make sense? Should not differ. But not tamper proof. Most developers work with Linux and/or MasOS. So might be you were hitting a but. But hopefully static building of assets will be removed soon, still working on it in https://github.com/apache/airflow/pull/56456 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
