dstandish commented on code in PR #60216:
URL: https://github.com/apache/airflow/pull/60216#discussion_r2759567963
##########
airflow-core/tests/unit/models/test_backfill.py:
##########
@@ -363,18 +368,54 @@ def test_active_dag_run(dag_maker, session):
dag_run_conf={"this": "param"},
)
assert b1 is not None
- with pytest.raises(AlreadyRunningBackfill, match="Another backfill is
running for dag"):
+
+ # Try to create overlapping backfill - should fail
+ with pytest.raises(AlreadyRunningBackfill, match="Another backfill is
running for Dag"):
Review Comment:
while reviewing this had an idea
I thought of something though.
Instead of evaluating overlapping range, don't worry about it. Instead,
when you are actually creating the backfill, just don't add the dates that are
already part of an active backfill.
So like if i have a backfill from jan 15 to feb 15 running now, and then i
create another request from feb 1 to march 1, the second one would still be
created but would only include the dates feb 16 through march 1.
This would seem to be maybe even more user-friendly
and would not require checking overlappingness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
